[webkit-reviews] review granted: [Bug 196593] [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK specific code : [Attachment 366703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 4 08:41:42 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 196593: [ATK] Use a smart pointer for AccessibilityObject wrapper and
remove GTK specific code
https://bugs.webkit.org/show_bug.cgi?id=196593

Attachment 366703: Patch

https://bugs.webkit.org/attachment.cgi?id=366703&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366703
  --> https://bugs.webkit.org/attachment.cgi?id=366703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366703&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324
>	       return 0;

return nullptr;

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350
> +    return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr;

Two more opportunities to return nullptr up above, as well.


More information about the webkit-reviews mailing list