[webkit-reviews] review granted: [Bug 196573] Add logging and ASSERTs to investigate issue with VPModuleInitialize : [Attachment 366688] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 196573: Add logging and ASSERTs to investigate issue with
VPModuleInitialize
https://bugs.webkit.org/show_bug.cgi?id=196573

Attachment 366688: Patch

https://bugs.webkit.org/attachment.cgi?id=366688&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 366688
  --> https://bugs.webkit.org/attachment.cgi?id=366688
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366688&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cp
p:81
> +    if (!library)
> +	   fprintf(stderr, "Cannot find VideoProcessingLibrary: %s\n",
dlerror());
> +    softLinkVideoProcessingVPModuleInitialize = (void (*)()) dlsym(library,
"VPModuleInitialize");
> +    if (!softLinkVideoProcessingVPModuleInitialize)
> +	   fprintf(stderr, "Cannot find function VPModuleInitialize: %s\n",
dlerror());

Is it OK that we will crash after logging either of these errors? Is it
possible to fall back to use an alternative library if this fails?