[webkit-reviews] review granted: [Bug 196409] Cache bytecode for jsc.cpp helpers and fix CachedStringImpl : [Attachment 366362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 17:17:36 PDT 2019

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 196409: Cache bytecode for jsc.cpp helpers and fix CachedStringImpl

Attachment 366362: Patch


--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366362
  --> https://bugs.webkit.org/attachment.cgi?id=366362

View in context: https://bugs.webkit.org/attachment.cgi?id=366362&action=review

> Source/JavaScriptCore/ChangeLog:30
> +	   which has a different shape and we crash.

Thanks for this explanation. It makes sense.

You should also write a sentence on what the fix is.

I wonder though if this shows us a more general bug in our encoding/decoding.

I wonder if we should have a more general solution of type matters when
encoding. So even if you have the same pointer twice, then you should encode it
twice? Maybe this leads to other issues. It probably does, like if you encode a
CodeBlock twice based on its type, that's probably bad.

But the issue we have now is a base class needs to be aware of its subclasses,
which ain't nice.

More information about the webkit-reviews mailing list