[webkit-reviews] review granted: [Bug 196396] UnlinkedCodeBlock constructor from cache should initialize m_didOptimize : [Attachment 366265] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 196396: UnlinkedCodeBlock constructor from cache should initialize
m_didOptimize
https://bugs.webkit.org/show_bug.cgi?id=196396

Attachment 366265: Patch

https://bugs.webkit.org/attachment.cgi?id=366265&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366265
  --> https://bugs.webkit.org/attachment.cgi?id=366265
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366265&action=review

r=me

I'm not sure how you found this, but I'm starting to think running all of
JetStream 2 with caching could be a good test to add.

> Source/JavaScriptCore/ChangeLog:9
> +	   The UnlinkedCodeBlock constructor in CachedTypes was missing the
initialization
> +	   for m_didOptimize, which leads to crashes in
CodeBlock::thresholdForJIT.

Please add a test.