[webkit-reviews] review granted: [Bug 194081] B3 should use associativity to optimize expression trees : [Attachment 366657] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 194081: B3 should use associativity to optimize expression trees
https://bugs.webkit.org/show_bug.cgi?id=194081

Attachment 366657: Patch

https://bugs.webkit.org/attachment.cgi?id=366657&action=review




--- Comment #16 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 366657
  --> https://bugs.webkit.org/attachment.cgi?id=366657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366657&action=review

r=me with the one nit that EliminateDeadCode doesn't need a class.

> Source/JavaScriptCore/b3/B3EliminateDeadCode.h:46
> +// This class and its run function are public, so that they can be called
directly from B3ReduceStrength
> +class EliminateDeadCode {
> +public:
> +    EliminateDeadCode(Procedure& proc)
> +	   : m_proc(proc)
> +    {
> +    }
> +
> +    bool run();
> +
> +private:
> +    Procedure& m_proc;
> +};

Seems like this should just be a function - maybe bool
eliminateDeadCodeImpl(Procedure&).