[webkit-reviews] review granted: [Bug 196387] Teach Call ICs how to call Wasm : [Attachment 366667] patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 196387: Teach Call ICs how to call Wasm
https://bugs.webkit.org/show_bug.cgi?id=196387

Attachment 366667: patch

https://bugs.webkit.org/attachment.cgi?id=366667&action=review




--- Comment #10 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 366667
  --> https://bugs.webkit.org/attachment.cgi?id=366667
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366667&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:1151
> -	       codePtr =
variant.executable()->generatedJITCodeForCall()->addressForCall(ArityCheckNotRe
quired);
> +
> +#if ENABLE(WEBASSEMBLY)
> +	       if (callLinkInfo.specializationKind() == CodeForCall) {
> +		   if (JSFunction* function = variant.function()) {
> +		       if (auto* wasmFunction =
jsDynamicCast<WebAssemblyFunction*>(vm, function))
> +			   codePtr = wasmFunction->jsCallEntrypoint();
> +		   }
> +	       }
> +#endif
> +
> +	       if (!codePtr)
> +		   codePtr =
variant.executable()->generatedJITCodeForCall()->addressForCall(ArityCheckNotRe
quired);

Seems like we write this code or some variant of it in multiple places.

Helper?