[webkit-reviews] review granted: [Bug 196530] [JSC] Add FuzzerAgent, which has a hooks to get feedback & inject fuzz data into JSC : [Attachment 366646] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 196530: [JSC] Add FuzzerAgent, which has a hooks to get feedback & inject
fuzz data into JSC
https://bugs.webkit.org/show_bug.cgi?id=196530

Attachment 366646: Patch

https://bugs.webkit.org/attachment.cgi?id=366646&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 366646
  --> https://bugs.webkit.org/attachment.cgi?id=366646
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366646&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:844
> +	       auto* fuzzerAgent = m_vm->fuzzerAgent();
> +	       if (UNLIKELY(fuzzerAgent))
> +		   return fuzzerAgent->getPrediction(codeBlock, bytecodeIndex,
prediction);

nit: I like to write this as a single line:
if (UNLIKELY(auto* fuzzerAgent = m_vm->fuzzerAgent()))

> Source/JavaScriptCore/runtime/RandomizingFuzzerAgent.cpp:36
> +SpeculatedType RandomizingFuzzerAgent::getPrediction(CodeBlock*, int,
SpeculatedType)

Can we enable this on some of our tests once we pass all tests with it? Maybe
worth filing a bug.