[webkit-reviews] review granted: [Bug 194944] [JSC] We should consider move UnlinkedFunctionExecutable::m_parentScopeTDZVariables to RareData : [Attachment 366398] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 194944: [JSC] We should consider move
UnlinkedFunctionExecutable::m_parentScopeTDZVariables to RareData
https://bugs.webkit.org/show_bug.cgi?id=194944

Attachment 366398: Patch

https://bugs.webkit.org/attachment.cgi?id=366398&action=review




--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 366398
  --> https://bugs.webkit.org/attachment.cgi?id=366398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366398&action=review

r=me with some comments.

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] We should consider move
UnlinkedFunctionExecutable::m_parentScopeTDZVariables to RareData

typo: move=>moving.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1278
> +	   bool m_cachedVariablesUnderTDZIsEmpty { false };

Nit: I think this is clearer as m_hasCachedVariablesUnderTDZ since that's the
active tense.