[webkit-reviews] review canceled: [Bug 196558] Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest() : [Attachment 366639] Work-in-progress
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 3 14:02:45 PDT 2019
John Wilander <wilander at apple.com> has canceled John Wilander
<wilander at apple.com>'s request for review:
Bug 196558: Pick up Ad Click Attribution conversions in
NetworkResourceLoader::willSendRedirectedRequest()
https://bugs.webkit.org/show_bug.cgi?id=196558
Attachment 366639: Work-in-progress
https://bugs.webkit.org/attachment.cgi?id=366639&action=review
--- Comment #5 from John Wilander <wilander at apple.com> ---
Comment on attachment 366639
--> https://bugs.webkit.org/attachment.cgi?id=366639
Work-in-progress
Sorry. Review comments are most welcome. I basically have the testing left
which is why I named it WiP. My plan is to both augment the API test for
WebCore::AdClickAttribution and to create a layout test that does the redirect
dance.
Removed review flag for now.
More information about the webkit-reviews
mailing list