[webkit-reviews] review granted: [Bug 191237] Remove SVG properties tear-off objects : [Attachment 366557] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 191237: Remove SVG properties tear-off objects
https://bugs.webkit.org/show_bug.cgi?id=191237

Attachment 366557: Patch

https://bugs.webkit.org/attachment.cgi?id=366557&action=review




--- Comment #138 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366557
  --> https://bugs.webkit.org/attachment.cgi?id=366557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366557&action=review

> Source/WebCore/svg/SVGAnimateElementBase.cpp:97
> +    m_hasInvalidCSSAttributeType = WTF::nullopt;

= { }

> Source/WebCore/svg/SVGAnimateElementBase.cpp:154
> +void SVGAnimateElementBase::calculateAnimatedValue(float percentage,
unsigned repeatCount, SVGSMILElement*)

"percentage" is the wrong term here, because it's 0-1, not 0-100. We usually
call this "progress"

> Source/WebCore/svg/SVGAnimateElementBase.cpp:192
> +	   return -1;

Better to return an Optional<float>

> Source/WebCore/svg/SVGElement.cpp:567
> +void SVGElement::synchronizeAllAnimatedSVGAttribute(SVGElement* svgElement)

Can we pass SVGElement&?

> Source/WebCore/svg/SVGViewElement.h:48
> +    // FIXME: svgAttributeChanged missing.

File a bug for this? It's not clear what the implications are.