[webkit-reviews] review granted: [Bug 196534] [ATK] Embed the AtkSocket as soon as we receive the plug ID : [Attachment 366592] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 3 08:07:13 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 196534: [ATK] Embed the AtkSocket as soon as we receive the plug ID
https://bugs.webkit.org/show_bug.cgi?id=196534

Attachment 366592: Patch

https://bugs.webkit.org/attachment.cgi?id=366592&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366592
  --> https://bugs.webkit.org/attachment.cgi?id=366592
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366592&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1236
>	   // Set the parent not to break bottom-up navigation.

Might as well fix this while you're at it: "to not break"


More information about the webkit-reviews mailing list