[webkit-reviews] review granted: [Bug 196511] Cursor count badge reverts to Zero during Drag & Drop of multiple items : [Attachment 366545] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 196511: Cursor count badge reverts to Zero during Drag & Drop of multiple
items
https://bugs.webkit.org/show_bug.cgi?id=196511

Attachment 366545: Patch

https://bugs.webkit.org/attachment.cgi?id=366545&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 366545
  --> https://bugs.webkit.org/attachment.cgi?id=366545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366545&action=review

Bade is UI. So, likely no way to test.

> Source/WebCore/page/DragController.cpp:-464
> -	       m_numberOfItemsToBeAccepted = numberOfFiles != 1 ? 0 : 1;

I can’t help but wonder, why? Why did we do this? I so want to understand the
comment, but it is broken English. Could this be a platform/port-specific hack?
Windows? GTK? If so, need to move hack. <—- not cq’ing because of this