[webkit-reviews] review granted: [Bug 196462] Resetting quota should take into account third party origins : [Attachment 366501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 18:44:29 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 196462: Resetting quota should take into account third party origins
https://bugs.webkit.org/show_bug.cgi?id=196462

Attachment 366501: Patch

https://bugs.webkit.org/attachment.cgi?id=366501&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 366501
  --> https://bugs.webkit.org/attachment.cgi?id=366501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366501&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:-2037
> -    // FIXME: Pass default third party quota as a parameter.

I think this is still worth fixing. A hard-coded / 10 is probably not the best
policy.


More information about the webkit-reviews mailing list