[webkit-reviews] review granted: [Bug 196458] Remove legacy webkitRequestAnimationFrame time quirk : [Attachment 366525] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 2 17:41:20 PDT 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 196458: Remove legacy webkitRequestAnimationFrame time quirk
https://bugs.webkit.org/show_bug.cgi?id=196458
Attachment 366525: Patch
https://bugs.webkit.org/attachment.cgi?id=366525&action=review
--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366525
--> https://bugs.webkit.org/attachment.cgi?id=366525
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=366525&action=review
> Source/WebCore/page/DOMWindow.cpp:1707
> + if (auto* document = this->document())
> + document->addConsoleMessage(MessageSource::JS,
MessageLevel::Warning, "webkitRequestAnimationFrame() is deprecated and will be
removed. Please use requestAnimationFrame() instead."_s);
Maybe this should be logged only once per document per load?
More information about the webkit-reviews
mailing list