[webkit-reviews] review granted: [Bug 177327] Implement white-space:break-spaces value : [Attachment 366495] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 177327: Implement white-space:break-spaces value
https://bugs.webkit.org/show_bug.cgi?id=177327

Attachment 366495: Patch

https://bugs.webkit.org/attachment.cgi?id=366495&action=review




--- Comment #54 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 366495
  --> https://bugs.webkit.org/attachment.cgi?id=366495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366495&action=review

r+ but Alan should look at the SimpleLineLayout changes.

> Source/WebCore/css/parser/CSSParserFastPaths.cpp:730
> +    case CSSPropertyLineBreak: // auto | loose | normal | strict |
after-white-space | break-spacess

s/break-spacess/break-spaces/

Also, shouldn't this new value be on "white-space" instead of "line-break"?

> LayoutTests/platform/ios/TestExpectations:3061
> +webkit.org/b/196169
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-
word-003.html [ ImageOnlyFailure ]

This is surprising, and I don't see anything in the ChangeLog about it.

> LayoutTests/platform/mac/TestExpectations:1690
> +webkit.org/b/196169
imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-
word-003.html [ ImageOnlyFailure ]

Ditto.