[webkit-reviews] review granted: [Bug 196513] Web Inspector: Remote Inspector indicate callback should always happen on the main thread : [Attachment 366547] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 2 16:41:49 PDT 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 196513: Web Inspector: Remote Inspector indicate callback should always
happen on the main thread
https://bugs.webkit.org/show_bug.cgi?id=196513
Attachment 366547: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=366547&action=review
--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 366547
--> https://bugs.webkit.org/attachment.cgi?id=366547
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=366547&action=review
r=me, looks good to me (especially because I was there when he was working on
it)
> Source/WebCore/ChangeLog:11
> + When we have a WebThread, don't just run on the WebThread run
NIT: there should be a semicolon between "WebThread" and "run".
More information about the webkit-reviews
mailing list