[webkit-reviews] review granted: [Bug 196478] [WK2] Add support for Window's beforeprint / afterprint events : [Attachment 366463] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 10:46:26 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 196478: [WK2] Add support for Window's beforeprint / afterprint events
https://bugs.webkit.org/show_bug.cgi?id=196478

Attachment 366463: Patch

https://bugs.webkit.org/attachment.cgi?id=366463&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 366463
  --> https://bugs.webkit.org/attachment.cgi?id=366463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366463&action=review

> Tools/WebKitTestRunner/TestController.cpp:268
> +    WKPageBeginPrinting(page, frame, WKPrintInfo { 1.0, 21.0, 29.7 });
> +    WKPageEndPrinting(page);

The definition of these is inside #if PLATFORM(COCOA).	I don't see any reason
why.


More information about the webkit-reviews mailing list