[webkit-reviews] review granted: [Bug 196474] [Web GPU] Implement blend states and color write mask for GPUColorStateDescriptor : [Attachment 366462] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 196474: [Web GPU] Implement blend states and color write mask for 
GPUColorStateDescriptor
https://bugs.webkit.org/show_bug.cgi?id=196474

Attachment 366462: Patch

https://bugs.webkit.org/attachment.cgi?id=366462&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 366462
  --> https://bugs.webkit.org/attachment.cgi?id=366462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366462&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:450
> +	   [descriptor setBlendingEnabled:YES];

Can we get some extra perf here by turning this off in some circumstances?