[webkit-reviews] review granted: [Bug 196504] NSAttributedString crashes when encoding text attachment cell for missing image : [Attachment 366522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 12:31:49 PDT 2019


Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 196504: NSAttributedString crashes when encoding text attachment cell for
missing image
https://bugs.webkit.org/show_bug.cgi?id=196504

Attachment 366522: Patch

https://bugs.webkit.org/attachment.cgi?id=366522&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 366522
  --> https://bugs.webkit.org/attachment.cgi?id=366522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366522&action=review

> Source/WebCore/editing/cocoa/HTMLConverter.mm:1342
> +	       NSBundle *webCoreBundle = [NSBundle
bundleWithIdentifier:@"com.apple.WebCore"];

We don't have a function for this?


More information about the webkit-reviews mailing list