[webkit-reviews] review granted: [Bug 181228] Web Inspector: [GTK] Copy copies to nowhere : [Attachment 366482] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 06:08:54 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 181228: Web Inspector: [GTK] Copy copies to nowhere

Attachment 366482: Patch


--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366482
  --> https://bugs.webkit.org/attachment.cgi?id=366482

View in context: https://bugs.webkit.org/attachment.cgi?id=366482&action=review

> Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:158
> +	   case ActionType:
> +	   case CheckableActionType: {

Is there no complaint from -Wimplicit-fallthrough? We have a FALLTHROUGH macro
that expands to a suitable attribute to avoid warnings here:

case ActionType:
case CheckableActionType: {

More information about the webkit-reviews mailing list