[webkit-reviews] review granted: [Bug 196466] Attr nodes are not cloned properly : [Attachment 366428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 18:52:03 PDT 2019


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 196466: Attr nodes are not cloned properly
https://bugs.webkit.org/show_bug.cgi?id=196466

Attachment 366428: Patch

https://bugs.webkit.org/attachment.cgi?id=366428&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 366428
  --> https://bugs.webkit.org/attachment.cgi?id=366428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366428&action=review

> Source/WebCore/dom/Document.cpp:992
>	   // FIXME: This will "Attr::normalize" child nodes of Attr.

Should we remove this FIXME?


More information about the webkit-reviews mailing list