[webkit-reviews] review granted: [Bug 196471] Add SPI to give injected bundles access to displayed PDFDocuments : [Attachment 366445] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 17:13:34 PDT 2019


Tim Horton <thorton at apple.com> has granted Remy Demarest
<rdemarest at apple.com>'s request for review:
Bug 196471: Add SPI to give injected bundles access to displayed PDFDocuments
https://bugs.webkit.org/show_bug.cgi?id=196471

Attachment 366445: Patch

https://bugs.webkit.org/attachment.cgi?id=366445&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 366445
  --> https://bugs.webkit.org/attachment.cgi?id=366445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366445&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.h:40
> +#ifdef __OBJC__

I feel like at this point you can just toss the whole file in #ifdef __OBJC__,
no need to open and close it a few times

> Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:36
> +#include <WebCore/Frame.h>

#import!


More information about the webkit-reviews mailing list