[webkit-reviews] review granted: [Bug 196453] Web Inspector: DOMDebugger: disabling a breakpoint for a specific event listener removes it from the UI : [Attachment 366423] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 16:10:55 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 196453: Web Inspector: DOMDebugger: disabling a breakpoint for a specific
event listener removes it from the UI
https://bugs.webkit.org/show_bug.cgi?id=196453

Attachment 366423: Patch

https://bugs.webkit.org/attachment.cgi?id=366423&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 366423
  --> https://bugs.webkit.org/attachment.cgi?id=366423
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366423&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:309
> +	       WI.domManager.removeEventListenerBreakpointsForNode(domNode);

Nice!


More information about the webkit-reviews mailing list