[webkit-reviews] review granted: [Bug 196086] Remove the SVG tear off objects for SVGMatrix, SVGTransfrom, SVGTransformList and SVGAnimatedTransformList : [Attachment 366429] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 196086: Remove the SVG tear off objects for SVGMatrix, SVGTransfrom,
SVGTransformList and SVGAnimatedTransformList
https://bugs.webkit.org/show_bug.cgi?id=196086

Attachment 366429: Patch

https://bugs.webkit.org/attachment.cgi?id=366429&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366429
  --> https://bugs.webkit.org/attachment.cgi?id=366429
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366429&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:20571
> +		725AB46F225295E700C73CF5 /* Recovered References */ = {
> +			isa = PBXGroup;
> +			children = (
> +				08CA3D4312894A3800FFF260 /* SVGMatrixTearOff.h
*/,
> +			);
> +			name = "Recovered References";
> +			sourceTree = "<group>";
> +		};

I don't think you want this project change.

> Source/WebCore/svg/SVGTransformValue.h:117
> +    FloatPoint translate() const

I wish this were called "translation"