[webkit-reviews] review granted: [Bug 195411] [PlayStation] Add initialization for JSC shell for PlayStation port : [Attachment 365763] Patch for JSC shell initialization for PlayStation port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 10:46:34 PDT 2019


Ross Kirsling <ross.kirsling at sony.com> has granted Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 195411: [PlayStation] Add initialization for JSC shell for PlayStation port
https://bugs.webkit.org/show_bug.cgi?id=195411

Attachment 365763: Patch for JSC shell initialization for PlayStation port

https://bugs.webkit.org/attachment.cgi?id=365763&action=review




--- Comment #17 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 365763
  --> https://bugs.webkit.org/attachment.cgi?id=365763
Patch for JSC shell initialization for PlayStation port

View in context: https://bugs.webkit.org/attachment.cgi?id=365763&action=review

Looks alright to me.

> Source/JavaScriptCore/shell/playstation/Initializer.cpp:32
> +__attribute__((constructor(101)))

The internet suggests you only need to specify the priority if there's more
than one?


More information about the webkit-reviews mailing list