[webkit-reviews] review granted: [Bug 196425] [JSC] JSRunLoopTimer::Manager should be small : [Attachment 366361] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 196425: [JSC] JSRunLoopTimer::Manager should be small
https://bugs.webkit.org/show_bug.cgi?id=196425

Attachment 366361: Patch

https://bugs.webkit.org/attachment.cgi?id=366361&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 366361
  --> https://bugs.webkit.org/attachment.cgi?id=366361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366361&action=review

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:124
> +	       PerVMData& data = *entry.value.get();

Normally if we are using the * operator, we don’t also need to call get().
Unless there is some special consideration here.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:202
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:232
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:264
> +    PerVMData& data = *iter->value.get();

Ditto.

> Source/JavaScriptCore/runtime/JSRunLoopTimer.cpp:282
> +    PerVMData& data = *iter->value.get();

Ditto.