[webkit-reviews] review granted: [Bug 196395] REGRESSION(r243512): Change locale of test in intl-datetimeformat.js : [Attachment 366263] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 05:51:12 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 196395: REGRESSION(r243512): Change locale of test in
intl-datetimeformat.js
https://bugs.webkit.org/show_bug.cgi?id=196395

Attachment 366263: Patch

https://bugs.webkit.org/attachment.cgi?id=366263&action=review




--- Comment #10 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 366263
  --> https://bugs.webkit.org/attachment.cgi?id=366263
Patch

It might be more interesting to test a locale other than English, but like Andy
says, the goal of this test was to show that hour:'2-digit' and hour:'numeric'
give different output, so it seems fine.

Why not just test 'pt-BR' though? Since it worked above, we already know it's
localized properly on all the platforms WebKit cares about, right?


More information about the webkit-reviews mailing list