[webkit-reviews] review denied: [Bug 189975] Remove StorageProcess : [Attachment 351142] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 189975: Remove StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=189975

Attachment 351142: Patch

https://bugs.webkit.org/attachment.cgi?id=351142&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 351142
  --> https://bugs.webkit.org/attachment.cgi?id=351142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351142&action=review

Patch looks good.

Please fix this EWS failure:

In file included from
/home/ews/gtk-wk2-ews/WebKit/WebKitBuild/Release/DerivedSources/WebKit/unified-
sources/UnifiedSource24.cpp:1:0:
../../Source/WebKit/StorageProcess/glib/StorageProcessMainGLib.cpp:30:28: fatal
error: StorageProcess.h: No such file or directory
 #include "StorageProcess.h"

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:102
> +		   time.sleep(5)

Was this change intentional? If so, you should explain its rationale in the
ChangeLog.