[webkit-reviews] review granted: [Bug 190033] [BigInt] BigInt.proptotype.toString is broken when radix is power of 2 : [Attachment 351068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 08:11:19 PDT 2018


Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 190033: [BigInt] BigInt.proptotype.toString is broken when radix is power
of 2
https://bugs.webkit.org/show_bug.cgi?id=190033

Attachment 351068: Patch

https://bugs.webkit.org/attachment.cgi?id=351068&action=review




--- Comment #4 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 351068
  --> https://bugs.webkit.org/attachment.cgi?id=351068
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351068&action=review

r=me with nits.

> Source/WTF/wtf/MathExtras.h:580
> +#if COMPILER(GCC_OR_CLANG)

Use `COMPILER(GCC_COMPATIBLE)`.


More information about the webkit-reviews mailing list