[webkit-reviews] review granted: [Bug 189283] [WebAuthN] Polish WebAuthN auto-test environment : [Attachment 351019] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 189283: [WebAuthN] Polish WebAuthN auto-test environment
https://bugs.webkit.org/show_bug.cgi?id=189283

Attachment 351019: Patch

https://bugs.webkit.org/attachment.cgi?id=351019&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 351019
  --> https://bugs.webkit.org/attachment.cgi?id=351019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351019&action=review

r=me

> Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp:582
> +	   MockWebAuthenticationConfiguration::Local local;

Any reason we are using a local variable instead of assigning straight into
configuration.local?

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:77
> +	   if (!configuration.local.value().acceptAuthentication) {

Cannot we use onfiguration.local->acceptAuthentication ?

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:90
> +	   if (!configuration.local.value().acceptAuthentication) {

ditto.

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:105
> +	   if (!configuration.local.value().acceptAttestation) {

ditto.

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:118
> +	       (__bridge CFDataRef)adoptNS([[NSData alloc]
initWithBase64EncodedString:configuration.local.value().privateKeyBase64
options:NSDataBase64DecodingIgnoreUnknownCharacters]).get(),

ditto.

> Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalService.cpp:45
> +    if (!m_configuration.local)

return !!m_configuration.local; ?