[webkit-reviews] review denied: [Bug 190056] REGRESSION (r230523): Caps lock indicator not shown in password field : [Attachment 351100] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 28 12:47:42 PDT 2018


Daniel Bates <dbates at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 190056: REGRESSION (r230523): Caps lock indicator not shown in password
field
https://bugs.webkit.org/show_bug.cgi?id=190056

Attachment 351100: Patch

https://bugs.webkit.org/attachment.cgi?id=351100&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 351100
  --> https://bugs.webkit.org/attachment.cgi?id=351100
Patch

This is not correct. Caps lock state could have changed when Safari is in the
background and a person may just focus the password field when they make Safari
the foreground app.


More information about the webkit-reviews mailing list