[webkit-reviews] review granted: [Bug 190075] cmake cannot run if python 2 isn't available : [Attachment 351078] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 28 10:49:46 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Mike Gorse
<mgorse at suse.com>'s request for review:
Bug 190075: cmake cannot run if python 2 isn't available
https://bugs.webkit.org/show_bug.cgi?id=190075

Attachment 351078: Patch.

https://bugs.webkit.org/attachment.cgi?id=351078&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 351078
  --> https://bugs.webkit.org/attachment.cgi?id=351078
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351078&action=review

> Source/cmake/WebKitCommon.cmake:24
>  
> +set(Python_ADDITIONAL_VERSIONS 3)
>      find_package(PythonInterp 2.7.0 REQUIRED)

The indentation is wrong here


More information about the webkit-reviews mailing list