[webkit-reviews] review granted: [Bug 190064] Don't use int offsets in StructureStubInfo : [Attachment 351036] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 190064: Don't use int offsets in StructureStubInfo
https://bugs.webkit.org/show_bug.cgi?id=190064

Attachment 351036: patch

https://bugs.webkit.org/attachment.cgi?id=351036&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 351036
  --> https://bugs.webkit.org/attachment.cgi?id=351036
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351036&action=review

r=me.

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:189
>	   RegisterSet usedRegisters;

I suggest moving this after the CodeLocations for better packing of this
struct.  It was well packed before with the trailing 32-bit ints.  It won't be
anymore with the 64-bit CodeLocations, unless we move it after.