[webkit-reviews] review granted: [Bug 189850] Deprecate ObjC SPI in Deprecated Xcode group : [Attachment 350739] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 189850: Deprecate ObjC SPI in Deprecated Xcode group
https://bugs.webkit.org/show_bug.cgi?id=189850

Attachment 350739: Patch

https://bugs.webkit.org/attachment.cgi?id=350739&action=review




--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 350739
  --> https://bugs.webkit.org/attachment.cgi?id=350739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350739&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.h:33
> -WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0))
> +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKUserContentController", macos(10.10,
WK_MAC_TBA), ios(8.0, WK_IOS_TBA))

Seems like this was a weird mix of user content and preferences. I guess there
is no single replacement in the modern API; should you mention WKPreferences as
well?