[webkit-reviews] review granted: [Bug 180643] [MSE] SourceBuffer::provideMediaData() may remove sample from decode queue unexpectedly : [Attachment 350964] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 180643: [MSE] SourceBuffer::provideMediaData() may remove sample from
decode queue unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=180643

Attachment 350964: Patch

https://bugs.webkit.org/attachment.cgi?id=350964&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 350964
  --> https://bugs.webkit.org/attachment.cgi?id=350964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350964&action=review

> LayoutTests/media/media-source/media-source-append-acb-no-frame-lost.html:42
> +	   let updateEnd = waitFor(sourceBuffer, 'updateend');
> +	   run('sourceBuffer.appendBuffer(initSegment)');
> +	   await updateEnd;

Just a little nit: because events will never be fired before the current
run-loop yields, it's safe to restructure this to:

run('sourceBuffer.appendBuffer(initSegment)');
await waitFor(sourceBuffer, 'updateend');

(I wish we could go back in time and change appendBuffer(...) to return a
Promise<void>.)