[webkit-reviews] review granted: [Bug 189976] Add VP8 support to WebRTC : [Attachment 350898] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 09:10:43 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189976: Add VP8 support to WebRTC
https://bugs.webkit.org/show_bug.cgi?id=189976

Attachment 350898: Patch

https://bugs.webkit.org/attachment.cgi?id=350898&action=review




--- Comment #10 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 350898
  --> https://bugs.webkit.org/attachment.cgi?id=350898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350898&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:130
> +    bool m_isSupportingVP8 { false };

Nit: I think "m_supportsVP8" would be better.


More information about the webkit-reviews mailing list