[webkit-reviews] review granted: [Bug 189375] document.open() should not propagate URLs to non-fully active documents : [Attachment 350919] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 09:10:30 PDT 2018


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189375: document.open() should not propagate URLs to non-fully active
documents
https://bugs.webkit.org/show_bug.cgi?id=189375

Attachment 350919: Patch

https://bugs.webkit.org/attachment.cgi?id=350919&action=review




--- Comment #13 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 350919
  --> https://bugs.webkit.org/attachment.cgi?id=350919
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350919&action=review

> LayoutTests/fast/dom/resource-locations-in-created-html-document.html:15
> +	   if (path == '/test')

s/==/===/

>
LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-inse
rtion/opening-the-input-stream/url.window-expected.txt:3
> +FAIL document.open() does not change document's URL (active but not fully
active document) null is not an object (evaluating 'childWin.location.href')

Do you know why we are failing this test?


More information about the webkit-reviews mailing list