[webkit-reviews] review granted: [Bug 190035] [GStreamer] Fix EncodedImage timestamps to match what libWebRTC expects : [Attachment 350957] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 190035: [GStreamer] Fix EncodedImage timestamps to match what libWebRTC
expects
https://bugs.webkit.org/show_bug.cgi?id=190035

Attachment 350957: Patch

https://bugs.webkit.org/attachment.cgi?id=350957&action=review




--- Comment #2 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 350957
  --> https://bugs.webkit.org/attachment.cgi?id=350957
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350957&action=review

Great catch, tricky problem, LGTM with some small changes.

> Source/WebCore/ChangeLog:12
> +	   all the GStreamer processing pipelines as the WebRTC object
basically wrap the "same"

Nit, wrap -> wraps

> Source/WebCore/ChangeLog:26
> +	   because of that issue.

Nit, is this a leftover?

>
Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
424
> +    std::map<GstClockTime, RtpTimestamps> m_ptsRtpTimestampMap;

We usually use HashMap type defined in WTF, is there any feature in the
std::maps that we want to use?