[webkit-reviews] review granted: [Bug 190028] Use enum class in createMarkup arguments : [Attachment 350953] Fix Windows build for real

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 190028: Use enum class in createMarkup arguments
https://bugs.webkit.org/show_bug.cgi?id=190028

Attachment 350953: Fix Windows build for real

https://bugs.webkit.org/attachment.cgi?id=350953&action=review




--- Comment #18 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 350953
  --> https://bugs.webkit.org/attachment.cgi?id=350953
Fix Windows build for real

View in context: https://bugs.webkit.org/attachment.cgi?id=350953&action=review

> Source/WebCore/editing/markup.h:58
> +enum class URLsToResolve { None, AllURLs, ExcludeLocalFiles };

It looks like this one is actually stored somewhere, so maybe it's worth making
the enum class narrower? (uint8_t)