[webkit-reviews] review granted: [Bug 189924] [MSE][GStreamer] Use sentinel buffer to detect end of append : [Attachment 350873] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 189924: [MSE][GStreamer] Use sentinel buffer to detect end of append
https://bugs.webkit.org/show_bug.cgi?id=189924

Attachment 350873: Patch

https://bugs.webkit.org/attachment.cgi?id=350873&action=review




--- Comment #12 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 350873
  --> https://bugs.webkit.org/attachment.cgi?id=350873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350873&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:159
> +    }, this, nullptr);

Would it be possible to pass a weak ptr here instead of `this`? The
AppendPipeline could inherit from CanMakeWeakPtr.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:281
> +    GST_TRACE_OBJECT(this, "posting end-of-append request to bus");

s/this/m_pipeline.get()

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:617
> +    GST_TRACE_OBJECT(this, "received end-of-append");

s/this/m_pipeline.get()

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:793
> +    GST_TRACE_OBJECT(this, "pushing data buffer %p", buffer);

Nit: Use GST_PTR_FORMAT
Also, s/this/m_pipeline.get() :)

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:811
> +    GST_TRACE_OBJECT(this, "pushing end-of-append buffer %p",
endOfAppendBuffer);

s/this/m_pipeline.get() and GST_PTR_FORMAT