[webkit-reviews] review granted: [Bug 190010] Split NaN-check into separate test : [Attachment 350900] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 190010: Split NaN-check into separate test
https://bugs.webkit.org/show_bug.cgi?id=190010

Attachment 350900: Patch

https://bugs.webkit.org/attachment.cgi?id=350900&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 350900
  --> https://bugs.webkit.org/attachment.cgi?id=350900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350900&action=review

> JSTests/ChangeLog:9
> +	   DataView exposes NaN-representation, which is not necessarily the
same on each
> +	   architecture. Therefore move the check of the NaN-representation
into its own
> +	   file such that we can disable this test on MIPS where
NaN-representation can be
> +	   different on older CPUs.

nit: Please move this underneath the "Reviewed by"