[webkit-reviews] review granted: [Bug 182406] Web Inspector: Hide DOM and XHR breakpoint sections when they are empty : [Attachment 350840] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 26 14:35:49 PDT 2018
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 182406: Web Inspector: Hide DOM and XHR breakpoint sections when they are
empty
https://bugs.webkit.org/show_bug.cgi?id=182406
Attachment 350840: Patch
https://bugs.webkit.org/attachment.cgi?id=350840&action=review
--- Comment #36 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 350840
--> https://bugs.webkit.org/attachment.cgi?id=350840
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=350840&action=review
r-me
> Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js:83
> if (!WI.debuggerManager.isBreakpointRemovable(this._breakpoint))
> - return false;
> + return true;
What does this mean?
> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css:-117
> -.sidebar > .panel.navigation.debugger .details-section.dom-breakpoints
.item.dom-node .icon {
> - content: url(../Images/DOMElement.svg);
> -}
This was lost. DOM Node Breakpoints have no icon with this patch.
Steps to Reproduce:
1. Inspect this page
2. Show Elements Tab
3. Right Click <body> and "Break on..." > Subtree Modified
4. Show Debugger Tab
=> DOM Node breakpoint missing icon.
> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:153
> + let createBreakpointButton = new
WI.ButtonNavigationItem("create-breakpoint", WI.UIString("Create Breakpoint"),
"Images/Plus13.svg", 13, 13);
This button should be a tad gray instead of black. File a follow-up?
> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:273
> + if (this._eventBreakpointTreeController) {
> + this._eventBreakpointTreeController.disconnect();
> + this._eventBreakpointTreeController = null;
> + }
> +
> + if (this._xhrBreakpointTreeController) {
> + this._xhrBreakpointTreeController.disconnect();
> + this._xhrBreakpointTreeController = null;
> + }
Dead code, remove.
> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:534
> + var pauseReasonBreakpointTreeElement =
this._pauseReasonTreeOutline.getCachedTreeElement(breakpoint);
Style: let
> Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js:539
> + var breakpointTreeElement =
this._breakpointsContentTreeOutline.getCachedTreeElement(breakpoint);
Style: let
> Source/WebInspectorUI/UserInterface/Views/EventBreakpointTreeElement.js:39
> - let subtitle = null;
> - if (linkifyNode && breakpoint.eventListener)
> - subtitle =
WI.linkifyNodeReference(breakpoint.eventListener.node);
> -
> + const subtitle = null;
Where did this go?
More information about the webkit-reviews
mailing list