[webkit-reviews] review granted: [Bug 189927] UIProcess should process incoming sync IPC from WebProcess when waiting for a sync IPC reply from it : [Attachment 350868] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 189927: UIProcess should process incoming sync IPC from WebProcess when
waiting for a sync IPC reply from it
https://bugs.webkit.org/show_bug.cgi?id=189927

Attachment 350868: Patch

https://bugs.webkit.org/attachment.cgi?id=350868&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 350868
  --> https://bugs.webkit.org/attachment.cgi?id=350868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350868&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:3361
> +    if (m_mainFrame && m_mainFrame->frameID() == frameID)
> +	   return;

Probably deserves a comment that we do this because of
decidePolicyForNavigationActionSync.

> Source/WebKit/UIProcess/WebPageProxy.cpp:3387
> +    if (m_process->webFrame(frameID))
> +	   return;

Ditto.