[webkit-reviews] review granted: [Bug 189998] [MediaStream] Clean up RealtimeMediaSource settings change handling : [Attachment 350869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 10:43:26 PDT 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 189998: [MediaStream] Clean up RealtimeMediaSource settings change handling
https://bugs.webkit.org/show_bug.cgi?id=189998

Attachment 350869: Patch

https://bugs.webkit.org/attachment.cgi?id=350869&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 350869
  --> https://bugs.webkit.org/attachment.cgi?id=350869
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350869&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:250
> +    void
notifySettingsDidChangeObservers(OptionSet<RealtimeMediaSourceSettings::Flag>);

s/notifySettingsDidChangeObservers/notifySettingsDidChange/ maybe?


More information about the webkit-reviews mailing list