[webkit-reviews] review granted: [Bug 189625] WebGL 2 Conformance: primitive restart and draw_primitive_restart WebGL2 sample : [Attachment 350780] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 189625: WebGL 2 Conformance: primitive restart and draw_primitive_restart
WebGL2 sample
https://bugs.webkit.org/show_bug.cgi?id=189625

Attachment 350780: Patch

https://bugs.webkit.org/attachment.cgi?id=350780&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 350780
  --> https://bugs.webkit.org/attachment.cgi?id=350780
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350780&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2009
> +unsigned WebGLRenderingContextBase::getMaxIndex(const
RefPtr<JSC::ArrayBuffer> elementArrayBuffer, GC3Dintptr uoffset, GC3Dsizei n)

I think you should pass in numElements raw, and do the / sizeof(T) inside here,
the same way you do with the uoffset.

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2053
> +	   maxIndex = getMaxIndex<GC3Duint>(buffer, offset, count);

... although I assume count here has already take the sizeof(T) into account?

> LayoutTests/webgl/webgl2-primitive-restart-expected.html:54
> +	   if(!isWebGL2) {

Nit: if <space> (