[webkit-reviews] review granted: [Bug 189695] REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on iOS : [Attachment 350750] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 189695: REGRESSION (PSON): White or Black flash occurs when process
swapping on navigation on iOS
https://bugs.webkit.org/show_bug.cgi?id=189695

Attachment 350750: patch

https://bugs.webkit.org/attachment.cgi?id=350750&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 350750
  --> https://bugs.webkit.org/attachment.cgi?id=350750
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350750&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1704
> +    [self _processWillChange];

It's weird that "process did exit" calls "process will change".
_processWillChange implies we're still attached to the old process but are
about to switch.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:165
> +    if (!m_drawingArea)
> +	   return;

Blank line after the return please.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:185
> +    if (!m_drawingArea)
> +	   return;

Blank line after the return please.

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:216
> +    [m_contentView _processDidExit];
> +    [m_webView _processWillSwap];

Please keep the contentView and webView methods the same.