[webkit-reviews] review granted: [Bug 189764] Import WPT tests for css custom properties api : [Attachment 350685] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 16:37:40 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 189764: Import WPT tests for css custom properties api
https://bugs.webkit.org/show_bug.cgi?id=189764

Attachment 350685: Patch

https://bugs.webkit.org/attachment.cgi?id=350685&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 350685
  --> https://bugs.webkit.org/attachment.cgi?id=350685
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350685&action=review

r=me

> LayoutTests/platform/mac-wk1/TestExpectations:625
> +imported/w3c/web-platform-tests/css/css-properties-values-api/ [ Skip ]
>  css-custom-properties-api [ Skip ]

Why is this feature not supported on WK1? That seems like a weird discrepancy.
We certainly shouldn't ship this feature only to WK2.


More information about the webkit-reviews mailing list