[webkit-reviews] review granted: [Bug 189290] [WHLSL] It shouldn’t be possible to use ternary expressions as l-values : [Attachment 350425] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Thomas Denney
<tdenney at apple.com>'s request for review:
Bug 189290: [WHLSL] It shouldn’t be possible to use ternary expressions as
l-values
https://bugs.webkit.org/show_bug.cgi?id=189290

Attachment 350425: Patch

https://bugs.webkit.org/attachment.cgi?id=350425&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 350425
  --> https://bugs.webkit.org/attachment.cgi?id=350425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350425&action=review

Should also remove the block from NormalUsePropertyResolver.

> Tools/WebGPUShadingLanguageRI/TernaryExpression.js:-41
> -    get isLValue() { return this._isLValue; }
> -    set isLValue(value) { this._isLValue = value; }

Similar to how CommaExpression.js has a comment about why it isn't an lvalue, a
comment here would be appreciated.