[webkit-reviews] review granted: [Bug 189902] offlineasm: fix macro scoping : [Attachment 350670] fix error reporting

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 189902: offlineasm: fix macro scoping
https://bugs.webkit.org/show_bug.cgi?id=189902

Attachment 350670: fix error reporting

https://bugs.webkit.org/attachment.cgi?id=350670&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 350670
  --> https://bugs.webkit.org/attachment.cgi?id=350670
fix error reporting

View in context: https://bugs.webkit.org/attachment.cgi?id=350670&action=review

r+ if your local testing doesn't show any issues and EWS bots are happy.

> Source/JavaScriptCore/offlineasm/transform.rb:137
> +$uniqueVarID = 0

nit: Let's name this uniqueMacroVarID since it's only used for macro vars.