[webkit-reviews] review granted: [Bug 189843] [MediaStream] Add mock window capture source : [Attachment 350664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 12:31:09 PDT 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 189843: [MediaStream] Add mock window capture source
https://bugs.webkit.org/show_bug.cgi?id=189843

Attachment 350664: Patch

https://bugs.webkit.org/attachment.cgi?id=350664&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 350664
  --> https://bugs.webkit.org/attachment.cgi?id=350664
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350664&action=review

> Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:142
> +    return RealtimeMediaSource::supportsSizeAndFrameRate(width, height,
rate);

That seems a bit odd here and below, Is there a way to improve things here?


More information about the webkit-reviews mailing list